Skip to content

Conversation

@jr
Copy link
Collaborator

@jr jr commented Jun 2, 2025

This UI is potentially too minimal, but there's a bit of a compromise: inactive-session isn't an error 100% of the time, but you do need to be able to get out of it.

Screenshot 2025-06-02 at 3 12 07 PM

Important

Add handling for inactive sessions and update UI to reflect authentication state in AuthService, CloudService, and AccountView.

  • Behavior:
    • Add inactive-session event to AuthService in AuthService.ts to handle transitions to inactive session state.
    • Log errors during session refresh in AuthService.ts.
    • Update CloudService.ts to listen for inactive-session events.
  • UI:
    • Update AccountView in AccountView.tsx to show login/logout buttons based on cloudIsAuthenticated state.
    • Add cloudIsAuthenticated to ExtensionState in ExtensionStateContext.tsx and update related components.
  • Tests:
    • Update ClineProvider.test.ts and ExtensionStateContext.test.tsx to test new authentication state handling.

This description was created by Ellipsis for 86ebeaa. You can customize this summary. It will automatically update as commits are pushed.

@jr jr requested review from cte and mrubens as code owners June 2, 2025 22:21
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jun 2, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 2, 2025
@jr jr merged commit 2fda064 into main Jun 2, 2025
18 checks passed
@jr jr deleted the jr/slightly-better-auth-refresh branch June 2, 2025 22:32
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 2, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants